[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after med

From: Amit Shah
Subject: Re: [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change
Date: Tue, 5 Apr 2011 14:28:32 +0530
User-agent: Mutt/1.5.21 (2010-09-15)

On (Tue) 05 Apr 2011 [09:40:05], Stefan Hajnoczi wrote:
> > See http://www.spinics.net/lists/linux-scsi/msg51504.html
> I don't think that patch updates the block inode size.  We'd need to
> call fs/block_dev.c:revalidate_disk() instead of directly calling
> cdi->disk->fops->revalidate_disk(cdi->disk).
> fs/block_dev.c:revalidate_disk() calls check_disk_size_change(), which
> will update the inode size.

Then the patch is buggy :-)  As Tejun also says in the thread, the
patch should be in the block layer, not sr.c.

(btw that patch does update /sys/block/sr0/size, so that part of
revalidation is done.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]