[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [RFC][PATCH 0/6] trace-state: make the behaviour of "di
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] Re: [RFC][PATCH 0/6] trace-state: make the behaviour of "disable" consistent across all backends |
Date: |
Wed, 6 Apr 2011 12:42:59 +0100 |
On Tue, Apr 5, 2011 at 2:30 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Mon, Apr 4, 2011 at 10:49 PM, Lluís <address@hidden> wrote:
>> This patch defines the "disable" trace event state to always use the "nop"
>> backend.
>>
>> As a side-effect, all events are now enabled (without "disable") by default,
>> as
>> all backends (except "stderr") have programmatic support for dynamically
>> (de)activating each trace event.
>>
>> In order to make this true, the "simple" backend now has a "-trace
>> events=<file>" argument to let the user select which events must be enabled
>> from
>> the very beginning.
>>
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>>
>> Lluís Vilanova (6):
>> trace: [ust] fix generation of 'trace.c' on events without args
>> trace: generalize the "property" concept in the trace-events file
>> trace-state: always use the "nop" backend on events with the "disable"
>> keyword
>> trace-state: [simple] disable all trace points by default
>> trace-state: [simple] add "-trace events" argument to control initial
>> state
>> trace: enable all events
>>
>>
>> docs/tracing.txt | 12 +-
>> qemu-config.c | 5 +
>> qemu-options.hx | 18 ++
>> scripts/tracetool | 88 +++++-------
>> trace-events | 385
>> ++++++++++++++++++++++++++---------------------------
>> vl.c | 94 ++++++++-----
>> 6 files changed, 313 insertions(+), 289 deletions(-)
>
> Excellent, thanks for implementing this. I'll review the patches in
> detail shortly.
I've left feedback on the individual patches. This is a nice cleanup,
thanks for doing this work!
The stderr backend is impacted - but not severely. You now need to
disable all trace events that should not generate output. Previously
it was the opposite; you needed to enable all trace events that should
generate output.
Adding Prerna (simpletrace) and Fabien (stderr) on CC so they can take a look.
I'd like to merge v2 into my tracing tree and send the qemu.git
maintainer a pull request soon.
Stefan
- [Qemu-devel] Re: [PATCH 3/6] trace-state: always use the "nop" backend on events with the "disable" keyword, (continued)
[Qemu-devel] [PATCH 6/6] trace: enable all events, Lluís, 2011/04/04
[Qemu-devel] Re: [RFC][PATCH 0/6] trace-state: make the behaviour of "disable" consistent across all backends, Stefan Hajnoczi, 2011/04/05
- [Qemu-devel] Re: [RFC][PATCH 0/6] trace-state: make the behaviour of "disable" consistent across all backends,
Stefan Hajnoczi <=