qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading
Date: Thu, 7 Apr 2011 09:43:42 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Apr 07, 2011 at 12:19:01AM -0000, address@hidden wrote:
> @@ -267,6 +267,9 @@ int load_multiboot(void *fw_cfg,
>              /* if a space comes after the module filename, treat everything
>                 after that as parameters */
>              target_phys_addr_t c = mb_add_cmdline(&mbs, initrd_filename);
> +            /* Kill spaces at the beginning of the filename */
> +            while( *initrd_filename == ' ' )
> +              initrd_filename++;

If we want to do this, shouldn't it be done before adding to the
multiboot command-line?  Otherwise the multiboot image also has to strip
leading spaces.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]