[Qemu-devel] Re: [PATCH v2 1/2] cdrom: Allow the TEST_UNIT_READY command after a cdrom change

[Amit Shah]

On (Thu) 07 Apr 2011 [09:42:30], Stefan Hajnoczi wrote:
> On Thu, Apr 07, 2011 at 10:35:18AM +0530, Amit Shah wrote:
> > @@ -1105,10 +1105,11 @@ static void ide_atapi_cmd(IDEState *s)
> >      /* If there's a UNIT_ATTENTION condition pending, only
> >         REQUEST_SENSE and INQUIRY commands are allowed to complete. */
> >      if (s->sense_key == SENSE_UNIT_ATTENTION &&
> > -   s->io_buffer[0] != GPCMD_REQUEST_SENSE &&
> > -   s->io_buffer[0] != GPCMD_INQUIRY) {
> > -   ide_atapi_cmd_check_status(s);
> > -   return;
> > +        s->io_buffer[0] != GPCMD_REQUEST_SENSE &&
> > +        s->io_buffer[0] != GPCMD_INQUIRY &&
> > +        s->io_buffer[0] != GPCMD_TEST_UNIT_READY) {
> > +        ide_atapi_cmd_check_status(s);
> > +        return;
> 
> Looks good but please update the comment.

Argh!  I'll update to a generic one as there are more commands that we
need to allow.

                Amit