[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] ppce500_mpc8544ds: Fix compile with --enable-de
From: |
Alexander Graf |
Subject: |
[Qemu-devel] Re: [PATCH] ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm |
Date: |
Fri, 8 Apr 2011 12:19:11 +0200 |
On 08.04.2011, at 12:08, David Gibson wrote:
> When configured with --enable-debug, we compile without optimization.
> This means that the function mpc8544_copy_soc_cell() in ppce500_mpc8544ds.c
> is not optimized out, even though it is never called without kvm. That in
> turn causes a link failure, because it calls the function
> kvmppc_read_host_property() which is in kvm_ppc.o and therefore not
> included in a --disable-kvm build.
>
> This patch fixes the problem by providing a dummy stub for
> kvmppc_read_host_property() in kvm_ppc.h when !CONFIG_KVM.
Looks good. When we get more such cases we should probably move this into our
own kvm-stub.c, but for now having it in a header is good enough.
I'll take this into the ppc-next tree and send a pull request shortly.
Alex