|
From: | Stefan Weil |
Subject: | [Qemu-devel] Re: [PATCH] w32: Fix compilation of new code |
Date: | Fri, 08 Apr 2011 21:49:46 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110307 Iceowl/1.0b1 Icedove/3.0.11 |
Am 03.04.2011 11:10, schrieb Blue Swirl:
On Thu, Mar 31, 2011 at 11:58 PM, Stefan Weil <address@hidden> wrote:Some recently added new code did not compile for w32 targets. The functions qemu_iohandler_fill and qemu_iohandler_poll need data type fd_set which is declared in winsock2.h for w32 targets. Moving the functions from qemu-common.h to qemu_socket.h fixes compilations for w32 without adding a new include file to qemu-common.h.There's nothing socket specific in qemu_iohandler_fill and qemu_iohandler_poll, so I'd rather fix qemu-common.h. But I have a patch in my working queue to move OS specific stuff to qemu-common.h, I'll fix this there.
Should I send a patch for qemu-common.h? This would need inclusion of winsock2.h for windows and fixing a conflict with json-lexer.c (which uses an enum value named ERROR)? w32 builds are now broken for more than a week (since 2011-03-29, commit 0298141998ea3e19fd86b5a7122aab2fd1ebad51). Best regards, Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |