qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching


From: Jordan Justen
Subject: Re: [Qemu-devel] [PATCH] pflash: Restore & fix lazy ROMD switching
Date: Sun, 10 Apr 2011 12:33:21 -0700

On Sun, Apr 10, 2011 at 03:53, Jan Kiszka <address@hidden> wrote:
> Commit 5145b3d1cc revealed a bug in the lazy ROMD switch-back logic, but
> resolved it by breaking that feature. This approach addresses the issue
> by switching back to ROMD after a certain amount of read accesses
> without further unlock sequences.

Without this change, the code will stay in flash mode until a single
read occurs.  The code sequence you are wanting to support using will
issue a read before trying to unlock again?

Actually, I suppose it will want to verify the written data before
moving on, so this does make sense.

Is the overhead of switching the modes significant enough to justify
the lazy switch-back?  (If so, maybe I'll look at this for cfi01 too.)

Thanks,

-Jordan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]