[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/6] atapi: Allow GESN after media change
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH v2 1/6] atapi: Allow GESN after media change |
Date: |
Tue, 12 Apr 2011 14:57:39 +0530 |
After a media change, the only commands allowed from the guest were
REQUEST_SENSE and INQUIRY. The guest may also issue
GET_EVENT_STATUS_NOTIFICATION commands to get media
changed notification.
Signed-off-by: Amit Shah <address@hidden>
---
hw/ide/core.c | 19 +++++++++++++------
1 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index c11d457..f839ef3 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1102,13 +1102,20 @@ static void ide_atapi_cmd(IDEState *s)
printf("\n");
}
#endif
- /* If there's a UNIT_ATTENTION condition pending, only
- REQUEST_SENSE and INQUIRY commands are allowed to complete. */
+ /*
+ * If there's a UNIT_ATTENTION condition pending, only
+ * REQUEST_SENSE, INQUIRY and GET_EVENT_STATUS_NOTIFICATION
+ * commands are allowed to complete. MMC-5, section 4.1.6.1 lists
+ * only these commands being allowed to complete, with other
+ * commands getting a CHECK condition response unless a higher
+ * priority status, defined by the drive here, is pending.
+ */
if (s->sense_key == SENSE_UNIT_ATTENTION &&
- s->io_buffer[0] != GPCMD_REQUEST_SENSE &&
- s->io_buffer[0] != GPCMD_INQUIRY) {
- ide_atapi_cmd_check_status(s);
- return;
+ s->io_buffer[0] != GPCMD_REQUEST_SENSE &&
+ s->io_buffer[0] != GPCMD_INQUIRY &&
+ s->io_buffer[0] != GPCMD_GET_EVENT_STATUS_NOTIFICATION) {
+ ide_atapi_cmd_check_status(s);
+ return;
}
switch(s->io_buffer[0]) {
case GPCMD_TEST_UNIT_READY:
--
1.7.4.2
- [Qemu-devel] [PATCH v2 0/6] atapi: Implement 'media' subcommand for GESN, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v2 1/6] atapi: Allow GESN after media change,
Amit Shah <=
- [Qemu-devel] [PATCH v2 3/6] atapi: GESN: Spin off No Event Available handling into own function, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v2 2/6] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v2 4/6] atapi: GESN: Use structs for commonly-used field types, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v2 5/6] atapi: GESN: implement 'media' subcommand, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v2 6/6] atapi: Save / load the new GESN event states during migration, Amit Shah, 2011/04/12