[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 4/5] atapi: GESN: Standardise event response hand
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH v5 4/5] atapi: GESN: Standardise event response handling for future additions |
Date: |
Tue, 12 Apr 2011 21:36:06 +0530 |
Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a
generic way so that future additions to the code to handle other
response types is easier.
Signed-off-by: Amit Shah <address@hidden>
---
hw/ide/core.c | 25 +++++++++++++++++++------
1 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 3fa2044..dafc049 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1098,9 +1098,17 @@ static void
handle_get_event_status_notification(IDEState *s,
uint8_t control;
} __attribute__((packed)) *gesn_cdb;
- unsigned int max_len;
+ struct {
+ uint16_t len;
+ uint8_t notification_class;
+ uint8_t supported_events;
+ } __attribute((packed)) *gesn_event_header;
+
+ unsigned int max_len, used_len;
gesn_cdb = (void *)packet;
+ gesn_event_header = (void *)buf;
+
max_len = be16_to_cpu(gesn_cdb->len);
/* It is fine by the MMC spec to not support async mode operations */
@@ -1111,12 +1119,17 @@ static void
handle_get_event_status_notification(IDEState *s,
return;
}
- /* polling */
+ /* polling mode operation */
+
/* We don't support any event class (yet). */
- cpu_to_ube16(buf, 0x00); /* No event descriptor returned */
- buf[2] = 0x80; /* No Event Available (NEA) */
- buf[3] = 0x00; /* Empty supported event classes */
- ide_atapi_cmd_reply(s, 4, max_len);
+ gesn_event_header->supported_events = 0;
+
+ gesn_event_header->notification_class = 0x80; /* No event available */
+ used_len = sizeof(*gesn_event_header);
+
+ gesn_event_header->len = cpu_to_be16(used_len
+ - sizeof(*gesn_event_header));
+ ide_atapi_cmd_reply(s, used_len, max_len);
}
static void ide_atapi_cmd(IDEState *s)
--
1.7.4.2
- [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v5 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v5 2/5] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v5 3/5] atapi: GESN: Use structs for commonly-used field types, Amit Shah, 2011/04/12
- [Qemu-devel] [PATCH v5 4/5] atapi: GESN: Standardise event response handling for future additions,
Amit Shah <=
- [Qemu-devel] [PATCH v5 5/5] atapi: GESN: implement 'media' subcommand, Amit Shah, 2011/04/12
- Re: [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN, Jes Sorensen, 2011/04/12
- Re: [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN, Paolo Bonzini, 2011/04/12
- Re: [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN, Kevin Wolf, 2011/04/13