Re: [Qemu-devel] [PATCH 1/4] [arm] trivial whitespace/indentation fixes

[Aurelien Jarno]

On Wed, Apr 13, 2011 at 06:16:55PM +0100, Peter Maydell wrote:
> On 13 April 2011 17:38, Lluís <address@hidden> wrote:
> > Signed-off-by: Lluís Vilanova <address@hidden>
> > ---
> >  target-arm/helper.c        |  246 
> > ++++++++++++++++++++++----------------------
> >  target-arm/iwmmxt_helper.c |   28 +++--
> >  target-arm/translate.c     |   26 ++---
> >  3 files changed, 150 insertions(+), 150 deletions(-)
> 
> My preference is not to do large-scale whitespace changes
> unless the code's being touched in that area anyway, so
> I'd prefer this not to be applied.
> 
> (They make things painful for forks and branches, and
> they make git blame less useful; disadvantages outweigh
> the minor benefits of the cleanup IMHO.)
> 

I agree that this patch should not be applied.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net