|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH] Fix conversions from pointer to tcg_target_long |
Date: | Thu, 14 Apr 2011 07:09:33 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 |
Am 14.04.2011 03:42, schrieb TeLeMan:
On Sat, Apr 2, 2011 at 19:36, Stefan Weil <address@hidden> wrote:tcg_gen_exit_tb takes a parameter of type tcg_target_long, so the type casts of pointer to long should be replaced by type casts of pointer to tcg_target_long (suggested by Blue Swirl). These changes are needed for build environments where sizeof(long) != sizeof(void *), especially for w64.There are many "(long)tb" in exec.c and the types of tb_next in TranslationBlock, tc_ptr in tb_find_pc(), searched_pc etc. are "unsigned long". So more patches for w64 are needed.
Yes, I am very aware of this fact. This is the third effort to get QEMU code which is w64 clean. The first two were large patches which were difficult to review. Now I send small patches which will finally achieve the same goal. Sometimes these small patches seem to be unrelated to w64 (like a recent patch which removes a parameter). I think that increasing portability of software has positive effects for all targets, not only the new one. That's why I do this although I don't use w64.
[Prev in Thread] | Current Thread | [Next in Thread] |