[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch
|
From: |
Brad Hards |
|
Subject: |
Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch |
|
Date: |
Sat, 16 Apr 2011 16:33:02 +1000 |
|
User-agent: |
KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.5.1; x86_64; ; ) |
On Sat, 16 Apr 2011 06:57:00 am Jan Vesely wrote:
> + s->status |= UHCI_STS_USBERR;
This is per UHCI 1.1D Section 4.1.5. Looks good.
> + *int_mask |= 0x02;
> + if (td->ctrl & TD_CTRL_IOC)
> + *int_mask |= 0x01;
> + uhci_update_irq(s);
I see "A hardware interrupt is signalled to the system", but can you provide a
little explanation of why this particular interrupt mask?
> + s->status |= UHCI_STS_USBERR;
This is per UHCI 1.1d Section 4.1.4. Looks good.
> + *int_mask |= 0x02;
> + if (td->ctrl & TD_CTRL_IOC)
> + *int_mask |= 0x01;
> + uhci_update_irq(s);
I see "A hardware interrupt is signalled to the system", but can you provide a
little explanation of why this particular interrupt mask?