[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 12/20] target-i386: fix helper_fxtract() wrt soft
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] [PATCH v2 12/20] target-i386: fix helper_fxtract() wrt softfloat |
Date: |
Wed, 20 Apr 2011 12:12:01 +0200 |
With softfloat it's not possible to play with the overflow of an
unsigned value to get the 0 case partially correct. Use a special case
for that. Using a division to generate an infinity is the easiest way
that works for both softfloat and softfloat-native.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>
---
target-i386/op_helper.c | 23 ++++++++++++++++-------
1 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index 22cb549..a4bf734 100644
--- a/target-i386/op_helper.c
+++ b/target-i386/op_helper.c
@@ -4005,15 +4005,24 @@ void helper_fpatan(void)
void helper_fxtract(void)
{
CPU86_LDoubleU temp;
- unsigned int expdif;
temp.d = ST0;
- expdif = EXPD(temp) - EXPBIAS;
- /*DP exponent bias*/
- ST0 = expdif;
- fpush();
- BIASEXPONENT(temp);
- ST0 = temp.d;
+
+ if (floatx_is_zero(ST0)) {
+ /* Easy way to generate -inf and raising division by 0 exception */
+ ST0 = floatx_div(floatx_chs(floatx_one), floatx_zero, &env->fp_status);
+ fpush();
+ ST0 = temp.d;
+ } else {
+ int expdif;
+
+ expdif = EXPD(temp) - EXPBIAS;
+ /*DP exponent bias*/
+ ST0 = int32_to_floatx(expdif, &env->fp_status);
+ fpush();
+ BIASEXPONENT(temp);
+ ST0 = temp.d;
+ }
}
void helper_fprem1(void)
--
1.7.2.3
- Re: [Qemu-devel] [PATCH v2 11/20] target-i386: fix helper_fbld_ST0() wrt softfloat, (continued)
- [Qemu-devel] [PATCH v2 04/20] softfloat: add pi constants, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 02/20] softfloat: fix floatx80_is_infinity(), Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 15/20] target-i386: replace approx_rsqrt and approx_rcp by softfloat ops, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 06/20] softfloat: add floatx80_compare*() functions, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 20/20] target-i386: switch to softfloat, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 19/20] target-i386: fix constants wrt softfloat, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 09/20] softfloat-native: add float*_is_any_nan() functions, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 12/20] target-i386: fix helper_fxtract() wrt softfloat,
Aurelien Jarno <=
- [Qemu-devel] [PATCH v2 16/20] target-i386: add CPU86_LDouble <-> double conversion functions, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 03/20] softfloat: add floatx80 constants, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 05/20] softfloat-native: add a few constant values, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 07/20] softfloat: fix float*_scalnb() corner cases, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 13/20] target-i386: fix helper_fdiv() wrt softfloat, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 18/20] target-i386: fix helper_fprem() and helper_fprem1() wrt softfloat, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 08/20] softfloat-native: fix float*_scalbn() functions, Aurelien Jarno, 2011/04/20
- [Qemu-devel] [PATCH v2 17/20] target-i386: fix logarithmic and trigonometric helpers wrt softfloat, Aurelien Jarno, 2011/04/20