Re: [Qemu-devel] [PATCH v2] qemu-img: Initial progress printing support

[Paolo Bonzini]

On 04/01/2011 04:58 PM, Stefan Hajnoczi wrote:
> On Fri, Apr 1, 2011 at 2:41 PM, Jes Sorensen<address@hidden>  wrote:
> > On 03/31/11 13:49, Stefan Hajnoczi wrote:
> > > On Thu, Mar 31, 2011 at 12:38 PM, Kevin Wolf<address@hidden>  wrote:
> > > > Am 31.03.2011 13:15, schrieb Jes Sorensen:
> > > > > On 03/31/11 12:38, Kevin Wolf wrote:
> > > > > I have been a little reluctant to do this because it will break the ABI
> > > > > for tools running qemu-img from a GUI etc.
> > > >
> > > > That's the reason for the "from a terminal" part. If we check for
> > > > isatty(), we should handle these cases just fine.
> > >
> > > Yes, I think checking for a tty is enough precaution and allows users
> > > to get the benefit of the progress bar.  TBH I'd probably forget to
> > > add -p half the time :).
> >
> > Ok, this is fine with me - however how do you suggest we offer the
> > option to disable it on the command line, an additional flag?

If you also check stdout/stderr for isatty (probably the progress output 
should go to stderr), "> /dev/null" is enough.

Paolo