Re: [Qemu-devel] [PATCH v2 06/11] trace: generalize the "property" concept in the trace-events file

[Stefan Hajnoczi]

On Wed, Apr 6, 2011 at 7:34 PM, Lluís <address@hidden> wrote:
> diff --git a/docs/tracing.txt b/docs/tracing.txt
> index 34b0901..a9fd85b 100644
> --- a/docs/tracing.txt
> +++ b/docs/tracing.txt
> @@ -38,7 +38,7 @@ generate code for the trace events.  Trace events are 
> invoked directly from
>  source code like this:
>
>     #include "trace.h"  /* needed for trace event prototype */
> -
> +
>     void *qemu_malloc(size_t size)
>     {
>         void *ptr;
> @@ -98,7 +98,7 @@ portability macros, ensure they are preceded and followed 
> by double quotes:
>  4. Name trace events after their function.  If there are multiple trace 
> events
>    in one function, append a unique distinguisher at the end of the name.
>
> -5. Declare trace events with the "disable" keyword.  Some trace events can
> +5. Declare trace events with the "disable" property.  Some trace events can
>    produce a lot of output and users are typically only interested in a subset
>    of trace events.  Marking trace events disabled by default saves the user
>    from having to manually disable noisy trace events.
> @@ -168,7 +168,7 @@ The st_change_trace_event_state() function can be used to 
> enable or disable trac
>  events at runtime inside QEMU:
>
>     #include "trace.h"
> -
> +
>     st_change_trace_event_state("virtio_irq", true); /* enable */
>     [...]
>     st_change_trace_event_state("virtio_irq", false); /* disable */

Tailing whitespace is there due to wiki formatting.  Please do not remove it.

The rest looks good.

Stefan