[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command |
Date: |
Wed, 27 Apr 2011 11:33:46 -0300 |
On Wed, 27 Apr 2011 09:54:34 +0800
Lai Jiangshan <address@hidden> wrote:
> On 04/26/2011 09:29 PM, Anthony Liguori wrote:
> > On 04/26/2011 08:26 AM, Luiz Capitulino wrote:
> >> On Thu, 21 Apr 2011 11:23:54 +0800
> >> Lai Jiangshan<address@hidden> wrote:
> >>
> >>>
> >>> Hi, Anthony Liguori
> >>>
> >>> Any suggestion?
> >>>
> >>> Although all command line interfaces will be converted to to use QMP
> >>> interfaces in 0.16,
> >>> I hope inject-nmi come into QAPI earlier, 0.15.
> >>
> >> I don't know what Anthony thinks about adding new commands like this one
> >> that
> >> early to the new QMP interface, but adding them to current QMP will
> >> certainly
> >> cause less code churn on your side. That's what I'd recommend for now.
> >
> > Yeah, sorry, this whole series has been confused in the QAPI discussion.
> >
> > I did not intend for QAPI to be disruptive to current development.
> >
> > As far as I can tell, the last series that was posted (before the QAPI
> > post) still had checkpatch.pl issues (scripts/checkpatch.pl btw) and we had
> > agreed that once that was resolved, it would come in through Luiz's tree.
> >
>
> Sorry, I didn't caught the meaning.
> Fix checkpatch.pl issues of V7 Patch, and sent it again?
Yes, my recommendation for your series is:
1. Address checkpatch.pl errors
2. Change the HMP to use your implementation, which send the NMI
to all CPUs
3. Any other _code_ review comments I might be missing
- Re: [Qemu-devel] [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command, (continued)
- Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command, Anthony Liguori, 2011/04/07
- Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command, Gleb Natapov, 2011/04/08
- Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command, Avi Kivity, 2011/04/10
- [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command, Lai Jiangshan, 2011/04/20
- Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command, Lai Jiangshan, 2011/04/20
- Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command, Luiz Capitulino, 2011/04/26
- Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command, Anthony Liguori, 2011/04/26
- Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command, Lai Jiangshan, 2011/04/26
- Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 1/2 V9] qemu, qmp: QError: New QERR_UNSUPPORTED, Lai Jiangshan, 2011/04/27
- [Qemu-devel] [PATCH 0/2 V9] hmp,qmp: add inject-nmi, Lai Jiangshan, 2011/04/27
- Re: [Qemu-devel] [PATCH 0/2 V9] hmp,qmp: add inject-nmi, Luiz Capitulino, 2011/04/29
- [Qemu-devel] [PATCH 2/2 V9] qmp, inject-nmi: convert do_inject_nmi() to QObject, Lai Jiangshan, 2011/04/27
- Re: [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command, Michael Roth, 2011/04/25
- [Qemu-devel] [RFC PATCH 1/3 V8] QError: Introduce QERR_UNSUPPORTED, Lai Jiangshan, 2011/04/20
- [Qemu-devel] [RFC PATCH 2/3 V8] qapi, nmi: add inject-nmi qmp command, Lai Jiangshan, 2011/04/20
- [Qemu-devel] [RFC PATCH 3/3 V8] qapi-hmp: Convert HMP nmi to use QMP, Lai Jiangshan, 2011/04/20