Re: [Qemu-devel] [PATCH 5/7] PPC: Implement e500 (FSL) MMU

[Scott Wood]

On Fri, 6 May 2011 14:00:35 +0200
Alexander Graf <address@hidden> wrote:

> +static inline void booke206_flush_tlb_one(ppc_tlb_t *tlb, int num)
> +{
> +    int i;
> +
> +    for (i = 0; i < num; i++) {
> +        if ((tlb[i].tlbe.prot & PAGE_VALID) &&
> +           !(tlb[i].tlbe.attr & MAS1_IPROT)) {
> +            tlb[i].tlbe.prot = 0;
> +        }
> +    }
> +}

When this is called on reset, we want to ignore IPROT.

The valid check seems unnecessary.

> +void helper_booke206_tlbsx(target_ulong address_hi, target_ulong address_lo)

What is address_hi?

From gen_tlbsx_booke206() it looks like these two arguments correspond to
the two operands, so shouldn't they be added together?  I only see
address_lo used.

-Scott