Re: [Qemu-devel] [PATCH 7/7] PPC: Qdev'ify e500 pci

[Paul Brook]

> @@ -250,7 +254,6 @@ static const VMStateDescription vmstate_ppce500_pci = {
> 
>      .minimum_version_id = 1,
>      .minimum_version_id_old = 1,
>      .fields      = (VMStateField[]) {
> 
> -        VMSTATE_PCI_DEVICE_POINTER(pci_dev, PPCE500PCIState),

Doesn't this require incrementing version_id?

> +    vmstate_register(&dev->qdev, ppce500_pci_id++, &vmstate_ppce500_pci,

ppce500_pci_id is bogus, and should be removed.
You probably shouldn't be calling this at all.  Instead use 
sysbus_register_withprop and qdev.vmsd.

Other than that, this patch looks ok.

Paul