[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] ahci: crash after duplicate bh registration
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] ahci: crash after duplicate bh registration |
|
Date: |
Mon, 09 May 2011 16:26:43 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 09.05.2011 16:12, schrieb Alexander Graf:
> On 05/08/2011 09:10 PM, Jan Kiszka wrote:
>> Hi Alex,
>>
>> I've seen crashes caused by ahci_check_cmd_bh unregistering a NULL bh.
>> It looks like ahci_dma_set_inactive can a called while there is already
>> a bh hanging around. Patch below cures the issue, but I have no clue if
>> such an invocation order is valid at all.
>
> It's certainly guest triggerable, so yes, let's check here.
>
> Acked-by: Alexander Graf <address@hidden>
Yes, the change makes sense to me. Please resend this as a proper patch,
Jan.
However, I still think Jan's question is valid: Is the AHCI emulation
supposed to run multiple DMA requests at once using the core.c
functions? I'd find it surprising if this actually worked well.
Kevin