Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Thu, 12 May 2011 17:05:12 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Its value is unreliable: a block device used as floppy has type
>> "floppy" if created with if=floppy, but type "hd" if created with
>> if=none.
>> 
>> That's because with if=none, the type is at best a declaration of
>> intent: the drive can be connected to any guest device.  Its type is
>> really the guest device's business.  Reporting it here is wrong.
>
> It reports how the guest is using the device, right? I'd say that's what
> users/clients are interested in knowing.

The value is *unreliable*.  It may or may not match how the guest is
using the device.  I doubt users are interested in unreliable
information.

> Also, we can't just drop it from QMP. We should first note it's deprecated.

Would you accept a change to the more honest value "unknown" for the
deprecation period?