[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block) |
Date: |
Thu, 12 May 2011 19:12:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Luiz Capitulino <address@hidden> writes:
> On Thu, 12 May 2011 17:05:12 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Its value is unreliable: a block device used as floppy has type
>> "floppy" if created with if=floppy, but type "hd" if created with
>> if=none.
>>
>> That's because with if=none, the type is at best a declaration of
>> intent: the drive can be connected to any guest device. Its type is
>> really the guest device's business. Reporting it here is wrong.
>
> It reports how the guest is using the device, right? I'd say that's what
> users/clients are interested in knowing.
The value is *unreliable*. It may or may not match how the guest is
using the device. I doubt users are interested in unreliable
information.
> Also, we can't just drop it from QMP. We should first note it's deprecated.
Would you accept a change to the more honest value "unknown" for the
deprecation period?
- Re: [Qemu-devel] [PATCH v2 1/5] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", (continued)
- Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Gerd Hoffmann, 2011/05/09
- Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Kevin Wolf, 2011/05/10
- [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 4/6] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 5/6] block: Remove type hint, it's guest matter, doesn't belong here, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 6/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/12
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Luiz Capitulino, 2011/05/12
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block),
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Luiz Capitulino, 2011/05/12
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/12
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Luiz Capitulino, 2011/05/12
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/13
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Luiz Capitulino, 2011/05/13
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/13
- Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Luiz Capitulino, 2011/05/13
[Qemu-devel] [PATCH v3 1/6] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", Markus Armbruster, 2011/05/12
[Qemu-devel] [PATCH v3 2/6] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd", Markus Armbruster, 2011/05/12
Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2011/05/12