Re: [Qemu-devel] [PATCH] Add AACI audio playback support to the ARM Versatile/PB platform

[Paul Brook]

> On the other hand the current ac97.c implementation is a closely coupled
> combination of a PCI/ACLink bridge (Intel 82801AA) with a generic AC97
> codec. This has prevent me to easily reuse this code.
> 
> The milkymist-ac97 implementation is another case. It looks like a basic
> implementation with the AC97 registers directly mapped on the system bus.
> 
> Using the ACLink bus I defined, it could be interesting to implement
> separately the PCI/ACLink bridge from ac97.c.
> 
> Is it what you mean by saying this should be shared with the other AC97
> devices ?

Yes. The whole point of AClink is that it separates the host bridge from the 
codec. We now have at least three devices implementing this.  Your aclink 
implementation is only used by one of these, which gives me little confidence 
it actually does what it claims.

Paul