[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_comman
From: |
Jonathan Nieder |
Subject: |
Re: [Qemu-devel] [regression] qemu-system-arm: segfault in lsi_do_command |
Date: |
Mon, 16 May 2011 13:35:10 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Paolo Bonzini wrote:
> This fixes it on top of my SCSI refactoring series.
Thanks! Works here, too, for what it's worth.
I squashed the following in when applying the "scsi: introduce
scsi_req_cancel" patch, for easier reading and to get a little closer
to warning-free compilation with gcc 4.6.
Signed-off-by: Jonathan Nieder <address@hidden>
---
hw/lsi53c895a.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index f291283..43de6f8 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -889,7 +889,6 @@ static void lsi_do_msgout(LSIState *s)
uint8_t msg;
int len;
uint32_t current_tag;
- SCSIDevice *current_dev;
lsi_request *current_req, *p, *p_next;
int id;
@@ -900,8 +899,6 @@ static void lsi_do_msgout(LSIState *s)
current_tag = s->select_tag;
current_req = lsi_find_by_tag(s, current_tag);
}
- id = (current_tag >> 8) & 0xf;
- current_dev = s->bus.devs[id];
DPRINTF("MSG out len=%d\n", s->dbc);
while (s->dbc) {
--
1.7.5.1