[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 17/18] usb-storage: don't call usb_packet_complete t
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 17/18] usb-storage: don't call usb_packet_complete twice |
Date: |
Mon, 16 May 2011 21:56:21 +0200 |
usb_msd_copy_data() may cause a recursive call to
usb_msd_command_complete() which in turn may complete
the packet, setting s->packet to NULL in case it does.
Recheck s->packet before calling usb_packet_complete()
to fix the double call.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb-msd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 7a08358..141da2c 100644
--- a/hw/usb-msd.c
+++ b/hw/usb-msd.c
@@ -253,7 +253,7 @@ static void usb_msd_command_complete(SCSIBus *bus, int
reason, uint32_t tag,
s->scsi_buf = s->scsi_dev->info->get_buf(s->scsi_dev, tag);
if (p) {
usb_msd_copy_data(s);
- if (s->usb_len == 0) {
+ if (s->packet && s->usb_len == 0) {
/* Set s->packet to NULL before calling usb_packet_complete
because another request may be issued before
usb_packet_complete returns. */
--
1.7.1
- [Qemu-devel] [PATCH 10/18] usb-linux: track aurbs in list, (continued)
- [Qemu-devel] [PATCH 10/18] usb-linux: track aurbs in list, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 11/18] usb-linux: walk async urb list in cancel, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 14/18] usb: add usb_handle_packet, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 02/18] usb: update config descriptors to identify number of interfaces, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 12/18] usb-linux: split large xfers, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 08/18] usb-linux: fix device path aka physical port handling, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 04/18] usb: add support for "grouped" interfaces and the Interface Association Descriptor, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 17/18] usb-storage: don't call usb_packet_complete twice,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 07/18] usb-linux: use usb_generic_handle_packet(), Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 15/18] usb: keep track of packet owner., Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 16/18] usb: move cancel callback to USBDeviceInfo, Gerd Hoffmann, 2011/05/16
- [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Gerd Hoffmann, 2011/05/16
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, David Ahern, 2011/05/16
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Gerd Hoffmann, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, David Ahern, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Gerd Hoffmann, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, David Ahern, 2011/05/17
- Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter, Gerd Hoffmann, 2011/05/17