|
| From: | Gerd Hoffmann |
| Subject: | Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter |
| Date: | Tue, 17 May 2011 16:36:55 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110419 Red Hat/3.1.10-1.el6_0 Thunderbird/3.1.10 |
Hi,
Right, you did not even try to work with Jan's tree. There is no reason the EHCI code could not have been brought in to qemu that way.
The usual way to review & merge code is to send a patch series against recent master to qemu-devel, optionally with a git tree to pull from. So I tried to do that for ehci by merging & rebasing Jan's tree. Didn't work out as described multiple times.
Using Jan's tree as-is isn't an option IMHO. The patches didn't got a serious review @ qemu-devel. IIRC the tree was more meant as "collect bits here so they doesn't get lost" not as "this stuff is ready for merge".
cheers, Gerd
| [Prev in Thread] | Current Thread | [Next in Thread] |