qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink
Date: Wed, 18 May 2011 10:31:18 +0100

On Tue, May 17, 2011 at 8:43 PM, Venkateswararao Jujjuri (JV)
<address@hidden> wrote:
> Signed-off-by: Venkateswararao Jujjuri "<address@hidden>
> ---
>  hw/9pfs/virtio-9p.c |   32 ++++++++++++++++----------------
>  1 files changed, 16 insertions(+), 16 deletions(-)

Please see my comment from v1:
"The len argument is redundant and not used by any callers, please just
return -errno and drop the len argument.  Callers rely on buf->size
instead."

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]