[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/21] scsi: introduce scsi_req_data
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 03/21] scsi: introduce scsi_req_data |
|
Date: |
Fri, 20 May 2011 17:52:16 +0200 |
|
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Tue, May 17, 2011 at 01:00:49PM +0200, Paolo Bonzini wrote:
> This abstracts calling the command_complete callback, reducing churn
> in the following patches.
Adding the helper sounds fine to me, but the name seems rather badly
chosen. What about scsi_req_get_more_data or similar? Either way
a comment above the function describing what it does would be useful,
too.
- [Qemu-devel] [PATCH v3 00/21] SCSI subsystem improvements, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 02/21] scsi-generic: Remove bogus double complete, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 01/21] scsi: add tracing of scsi requests, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 03/21] scsi: introduce scsi_req_data, Paolo Bonzini, 2011/05/17
- Re: [Qemu-devel] [PATCH v3 03/21] scsi: introduce scsi_req_data,
Christoph Hellwig <=
- [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 06/21] lsi: extract lsi_find_by_tag, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 05/21] scsi: reference-count requests, Paolo Bonzini, 2011/05/17
- [Qemu-devel] [PATCH v3 07/21] scsi: Use 'SCSIRequest' directly, Paolo Bonzini, 2011/05/17