qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 21/21] scsi: split command_complete callback


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 21/21] scsi: split command_complete callback in two
Date: Fri, 20 May 2011 19:44:24 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 05/20/2011 06:11 PM, Christoph Hellwig wrote:
+static void esp_command_complete(SCSIRequest *req, uint32_t arg)

Shouldn't the "arg" argument to the new ->command_complete be renamed
to something like "sense" or "status"?

+static void esp_transfer_data(SCSIRequest *req, uint32_t arg)
+{
+    ESPState *s = DO_UPCAST(ESPState, busdev.qdev, req->bus->qbus.parent);
+
+    DPRINTF("transfer %d/%d\n", s->dma_left, s->ti_size);
+    s->async_len = arg;
+    s->async_buf = scsi_req_get_buf(req);
+    if (s->dma_left) {
+        esp_do_dma(s);
+    } else if (s->dma_counter != 0&&  s->ti_size<= 0) {
+        /* If this was the last part of a DMA transfer then the
+           completion interrupt is deferred to here.  */

And for transfer_data "arg" should become "len".

True, I wanted to keep the patch as mechanical as possible. I'll add a 22nd patch doing it.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]