qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 21/26] target-xtensa: implement unaligned except


From: Max Filippov
Subject: Re: [Qemu-devel] [PATCH 21/26] target-xtensa: implement unaligned exception option
Date: Tue, 24 May 2011 03:20:35 +0400
User-agent: KMail/1.13.6 (Linux/2.6.34.8-68.fc13.x86_64; KDE/4.5.5; x86_64; ; )

> > This is also done by gen_load_store_alignment.
> > Does it really worth copying part of this logic to do_unaligned_access just 
> > to use ALIGNED_ONLY framework?
> 
> Yes, because it is done out-of-line, as a part of the TLB load slow path.

I probably just don't get what you call 'out-of-line'. In fact 
do_unaligned_access will be called for every unaligned access, and alignment 
condition will be checked for every access. It just happens in other place.
Does it have more chances to be optimized better than TCG code, or is it less 
TCG code itself that makes difference?

Thanks.
-- Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]