[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow2: Fix in-flight list after qcow2_cache_put
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH] qcow2: Fix in-flight list after qcow2_cache_put failure |
|
Date: |
Wed, 25 May 2011 15:20:26 +0200 |
|
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Tue, May 24, 2011 at 04:47:19PM +0200, Kevin Wolf wrote:
> If qcow2_cache_put returns an error during cluster allocation and the
> allocation fails, it must be removed from the list of in-flight allocations.
> Otherwise we'd get a loop in the list when the ACB is used for the next
> allocation.
>
> Luckily, this qcow2_cache_put shouldn't fail anyway because the L2 table is
> only read, so that qcow2_cache_put doesn't even involve I/O.
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>