[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev |
Date: |
Wed, 25 May 2011 17:13:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
David Gibson <address@hidden> writes:
> On Tue, May 24, 2011 at 01:45:07PM +0200, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> Cc: Alexander Graf <address@hidden>
>> Cc: David Gibson <address@hidden>
>> ---
>> hw/spapr_vio.c | 8 +++++++-
>> 1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c
>> index be535d6..fee4c46 100644
>> --- a/hw/spapr_vio.c
>> +++ b/hw/spapr_vio.c
>> @@ -52,6 +52,10 @@
>> static struct BusInfo spapr_vio_bus_info = {
>> .name = "spapr-vio",
>> .size = sizeof(VIOsPAPRBus),
>> + .props = (Property[]) {
>> + DEFINE_PROP_UINT32("irq", VIOsPAPRDevice, vio_irq_num, 0), \
>> + DEFINE_PROP_END_OF_LIST(),
>> + },
>> };
>
> I don't see what the point of this is. Absolute irq numbers have no
> special meaning in the XICS context, and the guest kernel will remap
> them to virtual irqs anyway.
Are the irq numbers guest-visible? If yes, a property may be required
to keep them stable across migration. Especially when hot-plug comes
into play.
[...]
- Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device, (continued)
Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device, David Gibson, 2011/05/24
[Qemu-devel] [PATCH 2/3] spapr: prepare for qdevification of irq, Paolo Bonzini, 2011/05/24
[Qemu-devel] [PATCH 3/3] spapr: make irq customizable via qdev, Paolo Bonzini, 2011/05/24
Re: [Qemu-devel] [PATCH 0/3] spapr qdevification, Markus Armbruster, 2011/05/24