|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] #include cleanliness |
Date: | Tue, 31 May 2011 08:43:48 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10 |
On 05/30/2011 04:06 AM, Avi Kivity wrote:
On 05/30/2011 01:06 AM, Anthony Liguori wrote:On 05/19/2011 09:17 AM, Avi Kivity wrote:My mother always told me to explicitly #include any headers need to compile a file, instead of relying on other #includes to bring them in. This patch fixes up targphys.h and cpu-common.h in this regard. Signed-off-by: Avi Kivity<address@hidden> --- cpu-common.h | 4 ++++ targphys.h | 2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index 151c32c..2009adc 100644 --- a/cpu-common.h +++ b/cpu-common.h @@ -18,6 +18,10 @@ #include "bswap.h" #include "qemu-queue.h" +#include "qemu-common.h" + +#include<stdbool.h>qemu-common.h should include stdbool. The idea behind qemu-common.h is to avoid direct includes to help with portability.Okay. But note qemu-common.h #includes cpu.h #includes qemu-common.h...
Fortunately, guards will prevent infinite recursion here :-)
I think osdep.h matches the "help with portability" label better, no?
I don't disagree, but that's not the purpose of osdep.h today. qemu-common.h is a header file that's more or less supposed to be included by everything.
It should prevent explicit #include's for system headers. Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |