|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface |
| Date: | Wed, 01 Jun 2011 17:29:56 +0300 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b3pre Thunderbird/3.1.10 |
On 06/01/2011 05:01 PM, Richard Henderson wrote:
> + err = dev->mmu->translate(dev, addr,&paddr,&plen, is_write); I see you didn't take my suggestion for using an opaque callback pointer. Really and truly, I won't be able to use this as-is for Alpha.
Rather than opaques, please pass the DMA engine itself and use container_of().
We should be removing opaques, not adding them. -- error compiling committee.c: too many arguments to function
| [Prev in Thread] | Current Thread | [Next in Thread] |