Re: [Qemu-devel] [RFC 00/10]: QMP/HMP: Introduce tray handling commands

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> In a recent discussion on the mailing list regarding the introduction of
> the BLOCK_TRAY_OPEN and BLOCK_TRAY_CLOSE events[1], it was mentioned that
> we need to fix the eject command and maybe introduce new commands first.
>
> Here's a my proposal.
>
> This series introduces three new commands:
>
>  o blockdev-tray-open: opens the drive tray. Also Supports removing the 
> inserted
>    media. The BLOCK_TRAY_OPEN event is emitted if this command succeeds.

Conflates tray control with media control.  Hmm.

>  o blockdev-tray-close: closes a drive tray. The BLOCK_TRAY_CLOSE event is
>    emitted.
>  o blockdev-media-insert: Inserts a media in the tray. The tray must empty
>    and already opened. No event is emitted.

What about separating tray control and media control like this:

* Tray control: either blockdev-tray-open and blockdev-tray-close, or a
  single blockdev-tray with a boolean argument.

* Media control: blockdev-media to change media.  Tray must be open, may
  or may not contain media.  Arguments specify new media, or no media.