[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] move WORDS_ALIGNED to qemu-common.h |
Date: |
Mon, 06 Jun 2011 15:15:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 |
On 06/06/2011 10:15 AM, Andreas Färber wrote:
> Am 06.06.2011 um 16:25 schrieb Paolo Bonzini:
>> +#if defined(__arm__) || defined(__sparc__) || defined(__mips__) ||
>> defined(__hppa__) || defined(__ia64__)
>> +#define WORDS_ALIGNED
>> +#endif
>
> Since it depends on the host and you're placing it directly under
> config-host.h inclusion, might it make sense to move the decision
> into configure instead, so that it ends up in config-host.h?
Hum, I now understand what Paulo was talking about elsewhere in the thread.
If he takes my suggestion to re-write the unaligned functions with GCC packed
support, these host ifdefs go away, and this objection disappears. The
question becomes one of ordering.
Do we take his existing 3-part patch as-is, and the packed patch as a followup?
Do we convert to packed accesses first and move it around after?
Do we do it all in one step?
r~