qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 3/3] spapr: make irq customizable via qdev
Date: Tue, 07 Jun 2011 11:05:42 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 06/07/2011 09:51 AM, Markus Armbruster wrote:
>  diff --git a/hw/spapr_vio.c b/hw/spapr_vio.c
>  index 6f34159..a193caa 100644
>  --- a/hw/spapr_vio.c
>  +++ b/hw/spapr_vio.c
>  @@ -52,6 +52,10 @@
>    static struct BusInfo spapr_vio_bus_info = {
>        .name       = "spapr-vio",
>        .size       = sizeof(VIOsPAPRBus),
>  +    .props = (Property[]) {
>  +        DEFINE_PROP_UINT32("irq", VIOsPAPRDevice, vio_irq_num, 0), \
>  +        DEFINE_PROP_END_OF_LIST(),
>  +    },
>    };

Out of this patch's scope, but I need to ask anyway: do devices on a
spapr-vio bus have a unique address?  If yes, what is it?

That would be the "reg" value in DEFINE_SPAPR_PROPERTIES (patch 2). I didn't make it a bus property because the default values varies according to the device type.

Is it okay to share interrupts?

Seems to work. :)

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]