Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Mon, 06 Jun 2011 08:08:51 -0500
> Anthony Liguori <address@hidden> wrote:
>
>> On 06/06/2011 04:25 AM, Kevin Wolf wrote:
>> > Am 02.06.2011 20:09, schrieb Luiz Capitulino:
>> >>>> I'm ok with either way. But in case you meant the second one, I guess
>> >>>> we should make "reason" a dictionary so that we can group related
>> >>>> information when we extend the field, for example:
>> >>>>
>> >>>>    "reason": { "no space": false, "no permission": true }
>> >
>> > Splitting up enums into a number of booleans looks like a bad idea to
>> > me. It makes things more verbose than they should be, and even worse, it
>> > implies that more than one field could be true.
>> 
>> I agree.  What I had suggested was to not have a reason at all.
>
> Is it better if we add a new enum to query-block? Like the "io-error" key we
> have talked about earlier? Like:
>
>  "io-error": "no space"
>
> We could have "no space", "low level" (that's how the man page defines EIO) 
> and
> "unknown".

As mentioned before, I prefer my errnos straight, not wrapped in a pile
of pseudo-abstractions that make me go to the source code to figure out
how to unwrap them :)