|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present |
Date: | Wed, 08 Jun 2011 14:28:38 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110419 Red Hat/3.1.10-1.el6_0 Thunderbird/3.1.10 |
@@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci) static void intel_hda_write_config(PCIDevice *pci, uint32_t addr, uint32_t val, int len) { - IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci); - pci_default_write_config(pci, addr, val, len); - if (d->msi) { - msi_write_config(pci, addr, val, len); - } + msi_write_config(pci, addr, val, len); }
Nothing device specific left in there now. If msi_write_config() checks itself whenever msi is enabled or not we could call it from pci_default_write_config(), then zap this function altogether, no?
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |