qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP an


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH][uq/master] kvm: x86: Save/restore FPU OP, IP and DP
Date: Mon, 13 Jun 2011 11:45:34 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b3pre Thunderbird/3.1.10

On 06/11/2011 12:23 PM, Jan Kiszka wrote:
From: Jan Kiszka<address@hidden>

These FPU states are properly maintained by KVM but not yet by TCG. So
far we unconditionally set them to 0 in the guest which may cause
state corruptions - not only during migration.


-#define CPU_SAVE_VERSION 12
+#define CPU_SAVE_VERSION 13


Incrementing the version number seems excessive - I can't imagine a real-life guest will break due to fp pointer corruption

However, I don't think we have a mechanism for optional state. We discussed this during the 18th VMState Subsection Symposium and IIRC agreed to re-raise the issue when we encountered it, which appears to be now.

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]