[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies |
Date: |
Tue, 14 Jun 2011 13:07:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-06-14 13:05, Alexander Graf wrote:
>
> On 08.06.2011, at 16:11, Jan Kiszka wrote:
>
>> No longer needed with accompanied kernel headers. We are only left with
>> build dependencies that are controlled by kvm arch headers.
>
> This should completely rule out all CAPs right? IIRC, all CAPs are defined in
> generic code, so we don't get number overlaps.
"We are only left with build dependencies that are controlled by kvm
arch headers." E.g. KVM_CAP_VCPU_EVENTS.
>
>>
>> CC: Alexander Graf <address@hidden>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> kvm-all.c | 8 --------
>> 1 files changed, 0 insertions(+), 8 deletions(-)
>>
>> diff --git a/kvm-all.c b/kvm-all.c
>> index 4a9910a..cbc2532 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -757,21 +757,17 @@ int kvm_init(void)
>> s->coalesced_mmio = kvm_check_extension(s, KVM_CAP_COALESCED_MMIO);
>>
>> s->broken_set_mem_region = 1;
>> -#ifdef KVM_CAP_JOIN_MEMORY_REGIONS_WORKS
>> ret = kvm_check_extension(s, KVM_CAP_JOIN_MEMORY_REGIONS_WORKS);
>> if (ret > 0) {
>> s->broken_set_mem_region = 0;
>> }
>> -#endif
>>
>> #ifdef KVM_CAP_VCPU_EVENTS
>
> ... which leaves the question why this one is still here :).
See above (does PPC support it?).
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script, (continued)
[Qemu-devel] [PATCH 10/12] kvm: Clean up stubs, Jan Kiszka, 2011/06/08
[Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers, Jan Kiszka, 2011/06/08
Re: [Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers, Stefan Weil, 2011/06/22