[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Reset system before loadvm
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] Reset system before loadvm |
Date: |
Tue, 14 Jun 2011 12:45:41 -0300 |
On Tue, 14 Jun 2011 14:14:58 +0300
Avi Kivity <address@hidden> wrote:
> On 06/14/2011 01:56 PM, Jan Kiszka wrote:
> > >
> > > I believe it is not. But regardless, we shouldn't add more incorrect
> > > behaviour.
> >
> > It depends on how the reset event is defined in QMP. As I see it, there
> > is nothing stated about reset reasons or sources. So emitting
> > information about the actually happening reset can't be incorrect. Just
> > like emitting the information about the VM stop/start around loadvm.
>
> I don't think so. Theoretically we could stop the vm, save a bit of
> state, reset it, and load the state back. Did a reset occur? Not from
> the user's point of view.
>
> If a reset event is interesting (personally I don't think it is, so
> much, perhaps just for logging purposes), we should restrict it to user
> visible events (so it means either the user pressed the reset button or
> the guest reset itself).
Yes, that's right. If the documentation (or even the code) is not
precise enough, we have to fix it.
Re: [Qemu-devel] [PATCH] Reset system before loadvm, Peter Maydell, 2011/06/12
[Qemu-devel] [PATCH 1/2] Allow silent system resets, Jan Kiszka, 2011/06/14
[Qemu-devel] [PATCH v2 2/2] Reset system before loadvm, Jan Kiszka, 2011/06/14