[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 8/8] linux-user/signal.c: Remove unused fenab
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 8/8] linux-user/signal.c: Remove unused fenab |
Date: |
Thu, 16 Jun 2011 17:37:15 +0100 |
Remove fenab as it is only written, never used. Add a FIXME
comment about the discrepancy between our behaviour and that
of the Linux kernel for this routine.
Signed-off-by: Peter Maydell <address@hidden>
---
linux-user/signal.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 2e34ffb..73670ac 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -2228,7 +2228,6 @@ void sparc64_set_context(CPUSPARCState *env)
target_mc_gregset_t *grp;
abi_ulong pc, npc, tstate;
abi_ulong fp, i7, w_addr;
- unsigned char fenab;
int err;
unsigned int i;
@@ -2293,7 +2292,11 @@ void sparc64_set_context(CPUSPARCState *env)
if (put_user(i7, w_addr + offsetof(struct target_reg_window, ins[7]),
abi_ulong) != 0)
goto do_sigsegv;
- err |= __get_user(fenab, &(ucp->tuc_mcontext.mc_fpregs.mcfpu_enab));
+ /* FIXME this does not match how the kernel handles the FPU in
+ * its sparc64_set_context implementation. In particular the FPU
+ * is only restored if fenab is non-zero in:
+ * __get_user(fenab, &(ucp->tuc_mcontext.mc_fpregs.mcfpu_enab));
+ */
err |= __get_user(env->fprs, &(ucp->tuc_mcontext.mc_fpregs.mcfpu_fprs));
{
uint32_t *src, *dst;
--
1.7.1
- [Qemu-devel] [PATCH 0/8] linux-user: Fix gcc 4.6 compile warnings, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 5/8] flatload: memp was a write-only variable, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 1/8] linuxload: id_change was a write only variable, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 3/8] linux-user: syscall should use sanitized arg1, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 8/8] linux-user/signal.c: Remove unused fenab,
Peter Maydell <=
- [Qemu-devel] [PATCH 4/8] flatload: end_code was only used in a debug message, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 6/8] linux-user: Bump do_syscall() up to 8 syscall arguments, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 2/8] syscall: really return ret code, Peter Maydell, 2011/06/16
- [Qemu-devel] [PATCH 7/8] linux-user/signal.c: Remove only-ever-set variable fpu_save_addr, Peter Maydell, 2011/06/16