|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH] Optimize screendump |
Date: | Sun, 19 Jun 2011 19:04:13 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 |
On 06/19/2011 06:53 PM, Andreas Färber wrote:
Am 19.06.2011 um 17:46 schrieb Avi Kivity:On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote:I wonder if this will break non-Linux platforms. Perhaps buffer an entire row of pixels instead and only fwrite(3) at the end of the outer loop.That's how I wrote this in the first place. Since the consensus is against these functions, I'll submit that version instead.Maybe add a qemu_fputc_unlocked() and do a configure check for it?
Good idea. I'll try that, unless people disagree. -- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |