[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests |
Date: |
Fri, 24 Jun 2011 17:34:26 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Fri, 24 Jun 2011, Peter Maydell wrote:
> On 24 June 2011 15:54, <address@hidden> wrote:
>
> > + if (!in->c.ds) {
> > + char *vfb = xenstore_read_str(NULL, "device/vfb");
> > + if (vfb == NULL) {
> > + /* there is no vfb, run vkbd on its own */
> > + in->c.ds = get_displaystate();
> > + } else {
> > + free(vfb);
>
> xenstore_read_str() returns a pointer from a qemu_strdup()
> so strictly this should be a qemu_free(), I think?
Yes, it should be, I'll send a second version of the patch.