qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_pri


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output
Date: Wed, 29 Jun 2011 10:33:41 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Red Hat/3.1.11-2.el6_1 Thunderbird/3.1.11

  Hi,

Erm, I'm not aware that my qdev bool patch got committed yet, so the
question of how to parse/print bool properties (on/off vs. yes/no) is
still undecided, no comments so far. It would be entirely possible to
let the author decide that on a case-by-case basis by using different
property type enums for the same 'bool' type.

Just accept both "on" and "yes" for true and both "off" and "no" for false?

For printing we'll have to pick one though. I'd tend to pick on/off as I guess most properties will enable or disable some feature. Or have the two enums ...

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]