qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string


From: Alon Levy
Subject: Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string
Date: Wed, 29 Jun 2011 16:25:43 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jun 29, 2011 at 03:03:32PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >-        dprint(d, 1, "%s: unexpected port 0x%x in vga mode\n", 
> >__FUNCTION__, io_port);
> >+        dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n",
> >+            __FUNCTION__, io_port, io_port_to_string(io_port));
> 
> Is this worth it?  Should be a quite rare event ...

well, it's helpful for debugging, so I don't see why not. The extra code is not 
that large,
and it's already written :)

> 
> cheers,
>   Gerd
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]