|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support |
Date: | Thu, 30 Jun 2011 12:46:59 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Red Hat/3.1.11-2.el6_1 Thunderbird/3.1.11 |
Hi,
Right - the whole ring assumes that the same side removes. of course we can add an IO for that (two - FREEZE and UNFREEZE). But I think this is the wrong approach. Instead, rendering all the commands, and dropping the wait for the client. Right now if we flush we do actually wait for the client, but I plan to remove this later. (we do this right now for update_area as well and that's much higher frequency).
To conclude, we still need to flush the command ring before stop. We don't want to change migration. So we still need to change spice server api. Gerd?
Yes, looks like there is no way around that to flush the command rings.When we have to change the spice-server api anyway, then we should support async I/O at libspice-server API level I think. Drop the qxl async thread, have a way to submit async requests to the worker, let libspice call us back on completion.
comments? cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |