[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove debugging messages.
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PATCH] Remove debugging messages. |
Date: |
Tue, 19 Jul 2011 21:59:29 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jul 19, 2011 at 03:04:22PM -0500, Anthony Liguori wrote:
> On 07/19/2011 02:23 PM, Richard W.M. Jones wrote:
> >From: "Richard W.M. Jones"<address@hidden>
> >
> >When using qemu -machine accel=kvm:tcg, if KVM is not available you
> >get a load of debugging output:
> >
> > Could not access KVM kernel module: No such file or directory
> > failed to initialize KVM: No such file or directory
> > Back to tcg accelerator.
>
> If you ask for kvm, and it can't be initialized, then shouldn't we
> alert the user about this?
That's one way to look at it.
Another is that libguestfs has specified that we want a "best effort".
Give me KVM, if available - great! If not, I don't really care, give
me TCG.
The -machine option isn't expressive enough to say all these things of
course.
BTW, it seems in 0.15 that the -machine option is now required? eg in
this case where it seems totally pointless:
$ qemu -nographic -device \?
KVM not supported for this target
No accelerator found!
This resulted in another bug and fix in libguestfs.
http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=d82438431c1551610eb7d9945fa76d6387534582
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org