[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] vmstate: complain about devices without vms
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] vmstate: complain about devices without vmstate |
Date: |
Wed, 20 Jul 2011 13:40:00 +0100 |
On 20 July 2011 11:09, Gerd Hoffmann <address@hidden> wrote:
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -283,7 +283,12 @@ int qdev_init(DeviceState *dev)
> qdev_free(dev);
> return rc;
> }
> - if (dev->info->vmsd) {
> + if (dev->info->vmsd == NULL) {
> + /* TODO: fixup qemu source code, then make this an assert() */
> + error_report("WARNING: device %s has no vmstate\n", dev->info->name);
> + } else if (dev->info->vmsd == VMSD_NONE) {
> + /* device doesn't need vmstate */;
> + } else {
I would prefer it if we didn't add this sort of targeted-at-qemu-developers
warning unless there was a reasonable period of time before the next release
where devices which provoke the warning message can be fixed. In particular,
should we postpone putting in the warning message until after 0.15 branches?
-- PMM
- [Qemu-devel] [PULL] non-migratable devices, Gerd Hoffmann, 2011/07/20
- [Qemu-devel] [PATCH 2/9] vmstate: complain about devices without vmstate, Gerd Hoffmann, 2011/07/20
- Re: [Qemu-devel] [PATCH 2/9] vmstate: complain about devices without vmstate,
Peter Maydell <=
- [Qemu-devel] [PATCH 1/9] vmstate: add no_migrate flag to VMStateDescription, Gerd Hoffmann, 2011/07/20
- [Qemu-devel] [PATCH 3/9] ahci doesn't support migration, Gerd Hoffmann, 2011/07/20
- [Qemu-devel] [PATCH 4/9] ehci doesn't support migration, Gerd Hoffmann, 2011/07/20
- [Qemu-devel] [PATCH 6/9] usb-wacom doesn't support migration, Gerd Hoffmann, 2011/07/20
- [Qemu-devel] [PATCH 5/9] usb storage: first migration support bits., Gerd Hoffmann, 2011/07/20
- [Qemu-devel] [PATCH 8/9] usb-net doesn't support migration, Gerd Hoffmann, 2011/07/20
- [Qemu-devel] [PATCH 7/9] usb-bt doesn't support migration, Gerd Hoffmann, 2011/07/20