[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach |
Date: |
Wed, 20 Jul 2011 18:24:25 +0200 |
BlockDriverState member buffer_alignment is initially 512. The device
model may set them, with bdrv_set_buffer_alignment(). If the device
model gets detached (hot unplug), the device's alignment is left
behind. Only okay because device hot unplug automatically destroys
the BlockDriverState. But that's a questionable feature, best not to
rely on it.
Signed-off-by: Markus Armbruster <address@hidden>
---
block.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index e9b911b..b94864c 100644
--- a/block.c
+++ b/block.c
@@ -736,6 +736,7 @@ void bdrv_detach_dev(BlockDriverState *bs, void *dev)
bs->dev = NULL;
bs->dev_ops = NULL;
bs->dev_opaque = NULL;
+ bs->buffer_alignment = 512;
}
/* TODO change to return DeviceState * when all users are qdevified */
--
1.7.2.3
- Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h, (continued)
[Qemu-devel] [PATCH 50/55] block: New bdrv_set_buffer_alignment(), Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 52/55] block: Move BlockDriverAIOCB & friends from block_int.h to block.h, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 38/55] scsi-disk: Preserve tray state on migration, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach,
Markus Armbruster <=
[Qemu-devel] [PATCH 37/55] ide/atapi: Preserve tray state on migration, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 41/55] fdc: Make media change detection more robust, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 30/55] block: Rename bdrv_set_locked() to bdrv_lock_medium(), Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 42/55] block: Clean up bdrv_flush_all(), Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 35/55] scsi-disk: Avoid physical/virtual tray state mismatch, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 45/55] block: Clean up remaining users of "removable", Markus Armbruster, 2011/07/20