[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup |
Date: |
Fri, 22 Jul 2011 12:10:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc15 Thunderbird/3.1.11 |
Am 22.07.2011 11:26, schrieb Frediano Ziglio:
> 2011/7/22 Kevin Wolf <address@hidden>:
>> Am 20.07.2011 15:56, schrieb Frediano Ziglio:
>>> These patches mostly cleanup some AIO code using coroutines.
>>> These patches apply to Kevin's repository, branch coroutine-block.
>>> Mostly they use stack instead of allocated AIO structure.
>>>
>>> Frediano Ziglio (5):
>>> qcow: allocate QCowAIOCB structure using stack
>>> qcow: QCowAIOCB field cleanup
>>> qcow: move some blocks of code to avoid useless variable
>>> initialization
>>> avoid dandling pointers
>>> qcow: small optimization initializing QCowAIOCB
>>>
>>> block/qcow.c | 210
>>> +++++++++++++++++++++++++--------------------------------
>>> block/qcow2.c | 38 +++-------
>>> 2 files changed, 102 insertions(+), 146 deletions(-)
>>
>> Most of it looks good now. Did you include the "RFC" in the subject just
>> because the coroutine work is in RFC state, too, or did you intend to
>> tell me that I shouldn't merge yet?
>>
>> Kevin
>>
>
> As these patches are first quite big patches I send (typo or small
> fixes do not counts) I just want to mark that I could write something
> really wrong. Just a way to avoid somebody having to send more patches
> and get more attention. Some projects are quite prone to merge even
> not that fine ones. I prefer to have some (a bit) pedantic comments
> and a real fix/improve.
>
> Now I removed the RFC from last update. The main reason is that I
> found your qemu-iotests repository which, I think should be merged to
> main repository, but it's just my opinion.
> Oh... qcow fails 004 test (even origin/coroutines-block) with a I/O error.
Yup, you're right, I must have messed it up. Care to fix it or should I
look into it?
> I must say there are a lot of small hidden things that a developer
> should know about Qemu, for instance
> - mailing list follow some LKML rules as CC ML and send to maintainer
> to get more attention
> - you can use scripts/checkpatch.pl to check your patches before send
>
> I still have also to understand how to use git format-patch/send-email
> correctly and "fluently" :)
That's true. Maybe you can update the wiki page with your findings?
The one suggestion I have for your use of git format-patch is
--subject-prefix="PATCH v3", so I don't get confused by the different
versions ;-)
Kevin
- [Qemu-devel] [RFC PATCH 1/5] qcow: allocate QCowAIOCB structure using stack, (continued)
- [Qemu-devel] [RFC PATCH 1/5] qcow: allocate QCowAIOCB structure using stack, Frediano Ziglio, 2011/07/20
- [Qemu-devel] [RFC PATCH 4/5] avoid dandling pointers, Frediano Ziglio, 2011/07/20
- [Qemu-devel] [RFC PATCH 5/5] qcow: small optimization initializing QCowAIOCB, Frediano Ziglio, 2011/07/20
- [Qemu-devel] [RFC PATCH 2/5] qcow: QCowAIOCB field cleanup, Frediano Ziglio, 2011/07/20
- [Qemu-devel] [RFC PATCH 3/5] qcow: move some blocks of code to avoid useless variable initialization, Frediano Ziglio, 2011/07/20
- Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup, Kevin Wolf, 2011/07/22
- Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup, Frediano Ziglio, 2011/07/22
- Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup, Kevin Wolf, 2011/07/25